Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RFC5646 data set and related tooling to include a new “viennese” variant and bumps the file date, while also refining code patterns and documentation formatting.
- Standardize example bullet formatting in README and remove trailing backslashes
- Switch to
await usingin HTTP download to ensure async disposal - Bump generated data date and add the "viennese" variant in code, JSON, and registry file
- Introduce normalization TODOs in lookup methods
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Unified list markers and stripped escape backslashes |
| LanguageTagsCreate/Program.cs | Updated to await using for httpStream disposal |
| LanguageTags/rfc5646DataGen.cs | Updated FileDate and inserted new “viennese” entry |
| LanguageTags/LanguageLookup.cs | Added TODOs to parse/normalize input before matching |
| LanguageData/rfc5646.json | Updated FileDate and added new “viennese” record |
| LanguageData/rfc5646 | Updated File-Date and appended “viennese” variant block |
Comments suppressed due to low confidence (3)
README.md:169
- The list markers and removal of trailing backslashes may affect Markdown rendering. Consider using a consistent single-hyphen plus space (
-) for bullets and ensure that line breaks render as intended.
- `pt` will match `pt` Portuguese, or `pt-BR` Brazilian Portuguese, or `pt-PT` European Portuguese.
LanguageTags/LanguageLookup.cs:119
- This TODO appears twice in separate methods. You may want to extract the parsing and normalization logic into a shared helper to avoid duplication and keep the code DRY.
// TODO: Conditional parse and normalize before processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.